Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qmk: Allow compile -j# to override config.compile.jobs #17624

Closed
wants to merge 1 commit into from
Closed

qmk: Allow compile -j# to override config.compile.jobs #17624

wants to merge 1 commit into from

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Jul 11, 2022

Description

I noticed that qmk compile -j19 didn't do anything. I discovered that there are also configuration settings compile.jobs and flash.jobs.

This change makes -j/--parallel override the setting from qmk config.

Testing performed:

  • Set compile.jobs and flash.jobs to distinct values
  • Ran qmk compile and qmk flash with various -j values and no -j value.
  • In each case, the printed commandline for gmake showed an appropriate "--jobs" value

As an alternative to this change, it might be time to remove/deprecate the -j flag of qmk compile/flash.

Types of Changes

  • Bugfix

Issues Fixed or Closed by This PR

  • I didn't report this as a separate issue, so there's no associated issue to close by this PR.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jepler
qmk: Allow compile -j# to override config.compile.jobs
2d0588d 
Otherwise, `qmk compile -j19` is accepted but makes no difference.

This also means that `flash -j#` overrides `config.flash.jobs`.
@github-actions github-actions bot added cli qmk cli command python labels Jul 11, 2022
@jepler
Copy link
Contributor Author

jepler commented Jul 11, 2022

Via Discord, I learned that before this change, -j19 doesn't work, while -j 19 does. I don't understand why this is, yet, but it probably means this change is not correct as proposed. In fact, it may be a problem with the milc library that qmk relies on.

@jepler jepler marked this pull request as draft July 11, 2022 16:01
@jepler jepler mentioned this pull request Jul 11, 2022
Open
@jepler jepler closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jepler